Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add cache lookup to TMC controllers #2939

Merged
merged 7 commits into from
Apr 5, 2023
Merged

🌱 Add cache lookup to TMC controllers #2939

merged 7 commits into from
Apr 5, 2023

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Mar 31, 2023

Summary

  • Use SyncTargets cache in resource controller
  • Add cache lookup to SyncTarget(Export) controllers

Related issue(s)

Fixes #2900

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@nrb
Copy link
Contributor Author

nrb commented Mar 31, 2023

/test all

@nrb nrb marked this pull request as ready for review April 3, 2023 20:05
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2023
@nrb nrb added the area/transparent-multi-cluster Related to scheduling of workloads into pclusters. label Apr 4, 2023
nrb added 6 commits April 4, 2023 14:24
@nrb
Use SyncTargets cache in resource controller
36f560c 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@nrb
Add cache lookup to SyncTarget(Export) controllers
759c1a4 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@nrb
Handle replicated synctarget deletion events
7abdab5 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@nrb
Use generics to do global cache lookup.
a447cdf 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@nrb
Use generic index lookup
0fc8909 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@nrb
Use cache lookup with fallback
67543d1 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@nrb nrb force-pushed the 2900-all-controllers branch from c8d02f5 to 67543d1 Compare April 4, 2023 20:02
@nrb
Copy link
Contributor Author

nrb commented Apr 4, 2023

Prow infra issues

 error: error creating buildah builder: reading signatures: downloading signatures for sha256:a68a70657f3ca82bb42b2830574edc9c02ba911a54aa7cb058a170ad845f1b42 in registry.build01.ci.openshift.org/ci/managed-clonerefs: received unexpected HTTP status: 504 Gateway Time-out

/retest

@davidfestal
Copy link
Member

/retest

stevekuznetsov
stevekuznetsov reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one comment.

pkg/reconciler/workload/synctargetexports/synctargetexports_controller.go Outdated Show resolved Hide resolved
@davidfestal davidfestal mentioned this pull request Apr 5, 2023
Closed
@nrb
Look up APIexports with fallback
1c83615 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@davidfestal
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2023
@davidfestal
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 419199c into kcp-dev:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@davidfestal davidfestal davidfestal left review comments

Assignees

@davidfestal davidfestal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/transparent-multi-cluster Related to scheduling of workloads into pclusters. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update all the TMC-related controller to use the cache informers where necessary
4 participants
@nrb @davidfestal @stevekuznetsov @openshift-merge-robot